Skip to content

Conversation

pandeysambhi
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
This Pr fixes 1071.
When there is a null response from backend for consumer lag, it shows NA instead of empty or blank.
Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@pandeysambhi pandeysambhi requested a review from a team as a code owner July 24, 2025 14:29
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jul 24, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi pandeysambhi! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@germanosin germanosin added the scope/frontend Related to frontend changes label Sep 14, 2025
@germanosin germanosin added this to the 1.4 milestone Sep 14, 2025
@github-project-automation github-project-automation bot moved this from Todo to PR Approved in Release 1.4 Sep 14, 2025
@Haarolean Haarolean added type/bug Something isn't working area/ux User experiense issues area/consumers and removed status/triage/manual Manual triage in progress labels Sep 14, 2025
@Haarolean Haarolean changed the title fix(#1071): show N/A when consumer lag is null FE: UX: Show N/A when consumer lag is null Sep 14, 2025
@Haarolean Haarolean enabled auto-merge (squash) September 14, 2025 10:40
@Haarolean Haarolean merged commit ac7dc22 into kafbat:main Sep 14, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from PR Approved to Done in Release 1.4 Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/consumers area/ux User experiense issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

FE: UX: Consumer lag = 0 when server returns null
3 participants